-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): remove unused CLI option from CNW #14865
Merged
FrozenPandaz
merged 1 commit into
nrwl:master
from
Coly010:angular/remove-ng-cli-options
Feb 10, 2023
Merged
feat(core): remove unused CLI option from CNW #14865
FrozenPandaz
merged 1 commit into
nrwl:master
from
Coly010:angular/remove-ng-cli-options
Feb 10, 2023
+10
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
FrozenPandaz,
AgentEnder,
vsavkin,
mandarini,
leosvelperez,
jaysoo and
bcabanes
as code owners
February 8, 2023 10:33
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
force-pushed
the
angular/remove-ng-cli-options
branch
from
February 8, 2023 11:23
7a777b2
to
3b2e089
Compare
mandarini
approved these changes
Feb 8, 2023
leosvelperez
requested changes
Feb 8, 2023
bcabanes
approved these changes
Feb 8, 2023
Coly010
force-pushed
the
angular/remove-ng-cli-options
branch
from
February 8, 2023 15:33
3b2e089
to
ca812b0
Compare
leosvelperez
reviewed
Feb 8, 2023
Coly010
force-pushed
the
angular/remove-ng-cli-options
branch
from
February 9, 2023 13:31
ca812b0
to
b197b19
Compare
leosvelperez
approved these changes
Feb 9, 2023
AgentEnder
approved these changes
Feb 9, 2023
FrozenPandaz
approved these changes
Feb 10, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We have an option to select the CLI to use when creating a new workspace, but it's never actually used.
We also want to only use Nx as the CLI moving forward.
Expected Behavior
Remove the CLI option to ensure reduced confusion
Related Issue(s)
Fixes #